Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1257
Birmingham | ITP-May-26 | Toluwalase Tiamiyu | Sprint 1 | Form Control#1257TTiamiyu wants to merge 2 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
TTiamiyu
added
📅 Sprint 1
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
TTiamiyu
changed the title
TTiamiyu
changed the title
|
@TTiamiyu |
TTiamiyu
added
the
Needs Review
Luro91
added
the
Review in progress
| this will also help you fill in your PR message later--> | ||
| <div> | ||
| <label for="name">name</label> | ||
| <input type="text"name="name" id="name" placeholder="Username" required> |
There was a problem hiding this comment.
The formatting standard for HTML elements is to use indentation on children elements. This makes it easier to understand the structure. How can you ensure consistent formatting in your code automatically?
There was a problem hiding this comment.
How can you ensure the form contains at least two non-space characters.
There was a problem hiding this comment.
i can automatically ensure code formatting by using of the code formatters like prettier, which is installed on my vs code, i would fix that now,
regarding the second comment, i google searched it and it shows that i can use a "pattern" attribute {\S.\S.*}
Luro91
added
Reviewed
|
I see erros in the w3 validator |
TTiamiyu
added
the
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit
| <select name="Select a color" id="Select a color" required> | ||
| <option value="" disabled selected>-- select a color --</option> |
There was a problem hiding this comment.
There are 2 errors in the w3 validtator:
Error: Bad value Select a color for attribute id on element select: An ID must not contain whitespace.
From line 28, column 9; to line 28, column 67
↩ ↩ Error: The value of the for attribute of the label element must be the ID of a non-hidden form control. From line 27, column 9; to line 27, column 27 ↩ Color<
Luro91
removed
the
Needs Review
3 participants
Learners, PR Template
Self checklist
Changelist
Enhances form accessibility and consistency by standardizing label capitalization and aligning input names and IDs. Updates option values for clarity and readability.